Re: [PATCH 1/5] hwmon: (pmbus/hac300s) Add error check for pmbus_read_word_data() return value

Next message: Guenter Roeck: "Re: [PATCH 2/5] hwmon: (pmbus/mp2975) Add error check for pmbus_read_word_data() return value"
Previous message: kernel test robot: "Re: [PATCH v6 9/9] power: sequencing: pcie-m2: Create serdev device for WCN7850 bluetooth"
In reply to: Pradhan, Sanman: "[PATCH 1/5] hwmon: (pmbus/hac300s) Add error check for pmbus_read_word_data() return value"
Next in thread: Pradhan, Sanman: "[PATCH 2/5] hwmon: (pmbus/mp2975) Add error check for pmbus_read_word_data() return value"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Guenter Roeck

Date: Tue Mar 17 2026 - 18:20:14 EST

On Tue, Mar 17, 2026 at 05:36:53PM +0000, Pradhan, Sanman wrote:
> From: Sanman Pradhan <psanman@xxxxxxxxxxx>
>
> hac300s_read_word_data() passes the return value of pmbus_read_word_data()
> directly to FIELD_GET() without checking for errors. If the I2C transaction
> fails, a negative error code is sign-extended and passed to FIELD_GET(),
> which silently produces garbage data instead of propagating the error.
>
> Add the missing error check before using the return value in
> the FIELD_GET() macro.
>
> Fixes: 669cf162f7a1 ("hwmon: Add support for HiTRON HAC300S PSU")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Sanman Pradhan <psanman@xxxxxxxxxxx>

Applied.

Thanks,
Guenter