Re: [PATCH v5 0/7] mfd: Add support for NXP MC33978/MC34978 MSDI

[Guenter Roeck]

Hi,

On 3/16/26 07:05, Oleksij Rempel wrote:
> This series adds support for the NXP MC33978/MC34978 Multiple Switch Detection
> Interface (MSDI) via the MFD framework.
>
> Architecture overview:
> * mfd: Core driver handling 2-frame pipelined SPI, regulator sequencing, and
>    linear irq_domain. Harvests status bits from SPI MISO MSB.
> * pinctrl: Exposes 22 physical switch inputs as standard GPIOs. Proxies IRQs to
>    the MFD domain.
> * hwmon: Exposes thermal limits, VBATP/VDDQ voltage boundaries, and dynamic
>    fault alarms.
> * mux: Controls the 24-to-1 AMUX routing analog signals (switch voltages,
>    temperature, VBATP) to an external ADC.
>
> Initial pinctrl implementation by David Jander, reworked into this MFD
> architecture.

Please have a look at the AI review feedback at
https://sashiko.dev/#/patchset/20260316140514.1406588-1-o.rempel%40pengutronix.de

It didn't run on all patches of the series, and I don't know how accurate
the feedback for the non-hwmon patches is, but at least for the hwmon
patch I agree with its findings.

Thanks,
Guenter