Re: [PATCH v1 1/1] hwmon: (isl28022) Don't check for specific errors when parsing properties
From: Andy Shevchenko
Date: Tue Mar 17 2026 - 17:12:07 EST
On Thu, Feb 19, 2026 at 03:21:29PM +0100, Geert Uytterhoeven wrote:
> On Thu, 19 Feb 2026 at 15:06, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > Instead of checking for the specific error codes (that can be considered
> > a layering violation to some extent) check for the property existence first
> > and then either parse it, or apply a default value.
> IIRC, we have removed superfluous presence checks all over the tree
> during the past few years? E.g. of_property_read_*() is documented to
> return -EINVAL if a property does not exist.
Implementation detail and actually not accurate.
> So this patch looks like a step back to me...
Not to me, just sent
20260317210828.2117631-1-andriy.shevchenko@xxxxxxxxxxxxxxx
to clarify in the documentation what's this about.
--
With Best Regards,
Andy Shevchenko