Re: [PATCH v2] vfio: selftests: only build tests on arm64 and x86_64
From: Ted Logan
Date: Tue Mar 17 2026 - 15:06:27 EST
On Tue, Mar 17, 2026 at 01:55:17PM +0000, Matt Evans wrote:
> On 03/02/2026 01:23, Ted Logan wrote:
> > diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> > index ead27892ab65..8e90e409e91d 100644
> > --- a/tools/testing/selftests/vfio/Makefile
> > +++ b/tools/testing/selftests/vfio/Makefile
> > @@ -1,3 +1,10 @@
> > +ARCH ?= $(shell uname -m)
> > +
> > +ifeq (,$(filter $(ARCH),arm64 x86_64))
>
> This fails to build (i.e. elides the build) on my local arm64 machine,
> because uname -m returns 'aarch64', not 'arm64'.
>
> Are you seeing an arm64 (Linux! [1]) machine where uname -m is 'arm64'...?
>
> This patch needs some translation, of the sort in
> tools/testing/selftests/mm/Makefile:15
>
>
> -Matt
>
> [1] Note on macOS/M-Mac, uname -m is indeed 'arm64', but not so on Linux.
I didn't have an aarch64 system handy to test when I sent my first
patch, so I went with David's comment in an earlier thread that x86_64
and arm64 are supported. I did just fire up a Linux VM on my Mac and I
see it does indeed report the arch as aarch64, and that it builds the
self-tests without warnings. I'll mail a patch to translate the
architecture as you suggest.
- Ted