Re: [PATCH rdma-next 1/1] RDMA/mana_ib: memory windows

From: Konstantin Taranov

Date: Tue Mar 17 2026 - 10:15:23 EST


>
> On Fri, Mar 06, 2026 at 02:57:58AM -0800, Konstantin Taranov wrote:
> > From: Konstantin Taranov <kotaranov@xxxxxxxxxxxxx>
> >
> > Implement .alloc_mw() and .dealloc_mw() for mana device.
> >
> > Signed-off-by: Konstantin Taranov <kotaranov@xxxxxxxxxxxxx>
> > ---
> > As I see that Jason's rdma_uapi is not in the next yet. I will make a
> > patch adding his helpers (e.g., ib_is_udata_in_empty() for mw) with
> > all other api calls.
> > drivers/infiniband/hw/mana/device.c | 3 ++
> > drivers/infiniband/hw/mana/mana_ib.h | 8 ++++
> > drivers/infiniband/hw/mana/mr.c | 57
> +++++++++++++++++++++++++++-
> > include/net/mana/gdma.h | 5 +++
> > 4 files changed, 72 insertions(+), 1 deletion(-)
>
> <...>
>
> > + err = mana_gd_send_request(gc, sizeof(req), &req, sizeof(resp),
> &resp);
> > + if (err || resp.hdr.status) {
> > + if (!err)
> > + err = -EPROTO;
> > +
> > + return err;
> > + }
>
> We already had this discussion about this specific pattern.
> https://lore.k/
> ernel.org%2Flinux-
> rdma%2F20260127141929.GV13967%40unreal%2F&data=05%7C02%7Ckotar
> anov%40microsoft.com%7C25731fedf33543d30a1008de83771e19%7C72f988
> bf86f141af91ab2d7cd011db47%7C1%7C0%7C639092744818898960%7CUnk
> nown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwM
> CIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&
> sdata=LjG%2B6fXmfART5jJrlV%2FawXB2QpwG9GzHj%2BfTmk0vuf0%3D&rese
> rved=0
>
> Please fix it first.

Sorry, I missed it. Thanks! I will send it soon.

- Konstantin

>
> Thanks