Re: [PATCH net-next] gve: add XDP metadata support for DQ RDA

[Joshua Washington]

Hello, the commit referenced here should have been
1b42e07af1ee ("gve: Add Rx HWTS metadata to AF_XDP ZC mode"). I had
mistakenly drawn the hash from a different repo. I can respin this
change once others have reviewed it and left potential feedback.


On Mon, Mar 16, 2026 at 6:04 PM Joshua Washington <joshwash@xxxxxxxxxx> wrote:
>
> Commit daa7ff1e1269 ("gve: Add Rx HWTS metadata to AF_XDP ZC mode")
> exposes support for the XDP RX timestamping metadata operation in the DQ
> RDA mode. While the operation works on its own, the intent was to enable
> XDP metadata support for the queue format as a whole along with it.
> Currently bfp_xdp_adjust_meta fails because meta_valid is set to false.
> This change updates xdp_buff preparation to set meta_valid to true, so
> metadata can be fully used by XDP programs.
>
> Reviewed-by: Harshitha Ramamurthy <hramamurthy@xxxxxxxxxx>
> Reviewed-by: Jordan Rhee <jordanrhee@xxxxxxxxxx>
> Signed-off-by: Joshua Washington <joshwash@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/google/gve/gve_rx_dqo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/google/gve/gve_rx_dqo.c b/drivers/net/ethernet/google/gve/gve_rx_dqo.c
> index 7924dce719e2..48945b4b6766 100644
> --- a/drivers/net/ethernet/google/gve/gve_rx_dqo.c
> +++ b/drivers/net/ethernet/google/gve/gve_rx_dqo.c
> @@ -877,7 +877,7 @@ static int gve_rx_dqo(struct napi_struct *napi, struct gve_rx_ring *rx,
>                                  buf_state->page_info.page_address +
>                                  buf_state->page_info.page_offset,
>                                  buf_state->page_info.pad,
> -                                buf_len, false);
> +                                buf_len, true);
>                 gve_xdp.gve = priv;
>                 gve_xdp.compl_desc = compl_desc;
>
> --
> 2.53.0.851.ga537e3e6e9-goog
>


--

Joshua Washington | Software Engineer | joshwash@xxxxxxxxxx | (414) 366-4423