Re: [PATCH v3 2/2] gpu: nova-drm: rename nova to nova-drm

[Danilo Krummrich]

On Tue Mar 17, 2026 at 2:20 PM CET, Alexandre Courbot wrote:
> On Tue Mar 17, 2026 at 6:23 PM JST, Cheng-Yang Chou wrote:
>> Rename the nova-drm driver directory from drivers/gpu/drm/nova/ to
>> drivers/gpu/drm/nova-drm/ and the top-level source file from nova.rs
>> to nova_drm.rs (matching the object name nova_drm.o) to follow the
>> kebab-case naming convention already used by the auxiliary device name.
>>
>> Update MAINTAINERS, Kconfig, and Makefile references accordingly.
>> Update the Kconfig help text to reflect the new module name nova-drm.
>>
>> Link: https://github.com/Rust-for-Linux/linux/issues/1228
>> Signed-off-by: Cheng-Yang Chou <yphbchou0911@xxxxxxxxx>
>> Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>
>> ---
>> Changes in v3:
>> - Rename subject line (John Hubbard)
>>
>>  MAINTAINERS                                            | 6 +++---
>>  drivers/gpu/drm/Kconfig                                | 2 +-
>>  drivers/gpu/drm/Makefile                               | 2 +-
>>  drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
>>  drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
>>  drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 0
>>  drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
>>  drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0
>
> That `drm/nova-drm` reads a bit awkwardly to me and feels unnecessary.
> Even `tegra-drm` is in `drm/tegra`.

Well, that's why I named it "nova" in the first place, but I don't want
KBUILD_MODNAME to diverge from the directory name and I also don't want the
driver name to diverge from KBUILD_MODNAME.

So, if we rename the driver name to nova-drm, then the other parts should be
renamed as well.