Re: [PATCH] firmware: arm_scmi: extract domain ID validation helpers

[Sudeep Holla]

On Tue, Mar 17, 2026 at 03:05:59PM +0300, Artem Shimko wrote:
> On Thu, Jan 22, 2026 at 7:17 PM Artem Shimko <a.shimko.dev@xxxxxxxxx> wrote:
> >
> > Refactor the voltage protocol implementation by moving repeated domain
> > ID boundary checks into dedicated inline functions. This reduces code
> > duplication and improves maintainability.
> >
> > The new helpers are scmi_voltage_domain_validate_id() which validates
> > a domain ID and returns an error code, and scmi_voltage_domain_lookup()
> > which returns a pointer to the domain structure or an error pointer.
> > These are used consistently across the voltage operations.
> > No functional changes are introduced - the validation logic remains
> > identical to the original inline checks.
> >
> 
> Hello maintainers,
> 
> Just a gentle ping.
> 
> Do you have any thoughts or feedback on this approach, or are these
> changes even irrelevant?
> 

I applied and then realised it is not necessary to churn so much to just
unify the domain ID validation. So I dropped it.

-- 
Regards,
Sudeep