Re: [PATCH] platform/x86: ISST: Correct locked bit width

From: Ilpo Järvinen

Date: Tue Mar 17 2026 - 09:05:30 EST


On Wed, 4 Mar 2026, Srinivas Pandruvada wrote:

> SST-PP locked bit width is set to three bits. It should be only one bit.
> Use SST_PP_LOCK_WIDTH define instead of SST_PP_LEVEL_WIDTH.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> ---
> drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> index b8cdaa233ea9..fa1726185d44 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> @@ -869,7 +869,7 @@ static int isst_if_get_perf_level(void __user *argp)
> _read_pp_info("current_level", perf_level.current_level, SST_PP_STATUS_OFFSET,
> SST_PP_LEVEL_START, SST_PP_LEVEL_WIDTH, SST_MUL_FACTOR_NONE)
> _read_pp_info("locked", perf_level.locked, SST_PP_STATUS_OFFSET,
> - SST_PP_LOCK_START, SST_PP_LEVEL_WIDTH, SST_MUL_FACTOR_NONE)
> + SST_PP_LOCK_START, SST_PP_LOCK_WIDTH, SST_MUL_FACTOR_NONE)

Doesn't this warrant a Fixes tag?

--
i.