[tip: irq/urgent] irqchip/riscv-rpmi-sysmsi: Fix mailbox channel leak in rpmi_sysmsi_probe()
From: tip-bot2 for Felix Gu
Date: Tue Mar 17 2026 - 06:22:31 EST
The following commit has been merged into the irq/urgent branch of tip:
Commit-ID: 76f0930d6e809234904cf9f0f5f42ee6c1dc694e
Gitweb: https://git.kernel.org/tip/76f0930d6e809234904cf9f0f5f42ee6c1dc694e
Author: Felix Gu <ustc.gu@xxxxxxxxx>
AuthorDate: Sun, 15 Mar 2026 15:17:54 +08:00
Committer: Thomas Gleixner <tglx@xxxxxxxxxx>
CommitterDate: Tue, 17 Mar 2026 11:16:15 +01:00
irqchip/riscv-rpmi-sysmsi: Fix mailbox channel leak in rpmi_sysmsi_probe()
When riscv_acpi_get_gsi_info() fails, the mailbox channel previously
requested via mbox_request_channel() is not freed. Add the missing
mbox_free_channel() call to prevent the resource leak.
Fixes: 4752b0cfbc37 ("irqchip/riscv-rpmi-sysmsi: Add ACPI support")
Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Reviewed-by: Rahul Pathak <rahul@xxxxxxxxxxxxxx>
Link: https://patch.msgid.link/20260315-sysmsi-v1-1-5f090c86c2ca@xxxxxxxxx
---
drivers/irqchip/irq-riscv-rpmi-sysmsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-riscv-rpmi-sysmsi.c b/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
index 5c74c56..612f397 100644
--- a/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
+++ b/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
@@ -250,6 +250,7 @@ static int rpmi_sysmsi_probe(struct platform_device *pdev)
rc = riscv_acpi_get_gsi_info(fwnode, &priv->gsi_base, &id,
&nr_irqs, NULL);
if (rc) {
+ mbox_free_channel(priv->chan);
dev_err(dev, "failed to find GSI mapping\n");
return rc;
}