Re: [PATCH net-next v2 1/3] net: dpaa2-mac: extend APIs related to statistics

[Ioana Ciornei]

On Mon, Mar 16, 2026 at 08:39:39PM -0700, Jakub Kicinski wrote:
> On Thu, 12 Mar 2026 16:22:47 +0200 Ioana Ciornei wrote:
> > Extend the dpmac_counter_id enum with the newly added counters which can
> > be interrogated through the MC firmware. Also add the
> > dpmac_get_statistics() API which can be used to retrieve multiple MAC
> > counters through a single firmware command.
> 
> >  #ifndef __FSL_DPMAC_H
> >  #define __FSL_DPMAC_H
> > @@ -170,6 +170,50 @@ int dpmac_set_link_state(struct fsl_mc_io *mc_io,
> >   *			      pause frames.
> >   * @DPMAC_CNT_EGR_GOOD_FRAME: counts frames transmitted without error, including
> >   *			      pause frames.
> > + * @DPMAC_CNT_EGR_FRAME_64: counts transmitted 64-bytes frames, good or bad.
> > + * @DPMAC_CNT_EGR_FRAME_127: counts transmitted 65 to 127-bytes frames, good or bad.
> > + * @DPMAC_CNT_EGR_FRAME_255: counts transmitted 128 to 255-bytes frames, good or bad.
> > + * @DPMAC_CNT_EGR_FRAME_511: counts transmitted 256 to 511-bytes frames, good or bad.
> > + * @DPMAC_CNT_EGR_FRAME_1023: counts transmitted 512 to 1023-bytes frames, good or bad.
> > + * @DPMAC_CNT_EGR_FRAME_1518: counts transmitted 1024 to 1518-bytes frames, good or bad.
> 
> please try to wrap netdev code at 80 chars, especially if it's just
> comments where wrapping doesn't hurt readability.
> 
> > + * @DPMAC_CNT_EGR_FRAME_1519_MAX: counts transmitted 1519-bytes frames and
> > + * larger (up to max frame length specified), good or bad.
> 
> Other entries in this doc prefix the continuation lines..
>

Ok, I will wrap them to 80 chars and format them the same as the other
entries.