Re: [PATCH v4 1/7] dt-bindings: iio: light: vcnl4000: add regulators

From: Krzysztof Kozlowski

Date: Tue Mar 17 2026 - 03:20:21 EST


On Mon, Mar 16, 2026 at 07:19:45PM +0200, Erikas Bitovtas wrote:
> These sensors can accept 2 supplies - one for the sensor and one for IR
> LED [1]. Add supply properties for the sensor - 2 for the sensors and
> one external, for their I2C bus, to ensure the sensor is powered on
> before proceeding with setup.
>
> [1] https://www.vishay.com/docs/84274/vcnl4040.pdf
>
> Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>
> Signed-off-by: Erikas Bitovtas <xerikasxx@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> index 2ba4d5de4ec4..a1b4c02db246 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> @@ -33,6 +33,10 @@ properties:
> interrupts:
> maxItems: 1
>
> + vdd-supply: true
> + vddio-supply: true
> + vled-supply: true

Same comments as before, I do not see improvements.

Best regards,
Krzysztof