Re: [PATCH] mtd: rawnand: pl353: make sure optimal timings are applied
From: Olivier Sobrie
Date: Tue Mar 17 2026 - 03:05:20 EST
Hello Miquel,
On Mon, Mar 16, 2026 at 09:46:39AM +0100, Miquel Raynal wrote:
> Hello Olivier,
>
> + Andrea
>
> On 04/03/2026 at 22:18:23 +01, Olivier Sobrie <olivier@xxxxxxxxx> wrote:
>
> > Timings of the nand are adjusted by pl35x_nfc_setup_interface() but
> > actually applied by the pl35x_nand_select_target() function.
> > If there is only one nand chip, the pl35x_nand_select_target() will only
> > apply the timings once since the test at its beginning will always be true
> > after the first call to this function. As a result, the hardware will
> > keep using the default timings set at boot to detect the nand chip, not
> > the optimal ones.
> >
> > With this patch, we program directly the new timings when
> > pl35x_nfc_setup_interface() is called.
> >
> > Signed-off-by: Olivier Sobrie <olivier@xxxxxxxxx>
>
> Nice, this probably will deserve a Fixes tag and Cc: stable.
Do you implicitely suggest that I should send a v2 of this patch
with Fixes tag and stable in CC? Or do you take care of that?
Thanks,
Olivier