Re: [PATCH v10 2/7] dt-bindings: media: qcom,x1e80100-camss: Add optional PHY handle definitions

[Bryan O'Donoghue]

On 16/03/2026 07:31, Krzysztof Kozlowski wrote:
> > +patternProperties:
> > +  "^phy@[0-9a-f]+$":
> > +    $ref: /schemas/phy/qcom,x1e80100-csi2-phy.yaml
> > +    unevaluatedProperties: false
> > +
> > +  "^opp-table(-.*)?$":
> Why do you expect multiple opp-tables?
>
> And where are operating-points phandle? Please look how other bindings
> do it.
>
> > +    type: object
> > +
> >   required:
> >     - compatible
> >     - reg
> > @@ -175,8 +201,6 @@ required:
> >     - iommus
> >     - power-domains
> >     - power-domain-names
> > -  - vdd-csiphy-0p8-supply
> > -  - vdd-csiphy-1p2-supply
> >     - ports
> >   
> >   additionalProperties: false
> > @@ -188,6 +212,7 @@ examples:
> >       #include <dt-bindings/clock/qcom,x1e80100-camcc.h>
> >       #include <dt-bindings/interconnect/qcom,icc.h>
> >       #include <dt-bindings/interconnect/qcom,x1e80100-rpmh.h>
> > +    #include <dt-bindings/phy/phy.h>
> >       #include <dt-bindings/power/qcom-rpmpd.h>
> >   
> >       soc {
> > @@ -233,6 +258,10 @@ examples:
> >                           "vfe_lite0",
> >                           "vfe_lite1";
> >   
> > +            #address-cells = <2>;
> > +            #size-cells = <2>;
> > +            ranges;
> Again, incomplete example. Where the the phy?

Both of these q's can be answered by adding a phys to the example, which 
I will do.

---
bod