RE: [RFC PATCH v3 1/4] wifi: rtl8xxxu: move dynamic_tx_rpt_timing_counter from ra_info to priv

[Ping-Ke Shih]

Georg Müller <georgmueller@xxxxxxx> wrote:
> Am 16.03.26 um 07:17 schrieb Ping-Ke Shih:
> >
> > Georg Müller <georgmueller@xxxxxxx> wrote:
> >> dynamic_tx_rpt_timing_counter is not per mac_id, but used across all
> >> mac_ids.
> >
> > I don't know the purpose of dynamic_tx_rpt_timing_counter. Could you
> > share your study?
> >
> It is used globally (not per mac) like this in the vendor driver as well [1][2].
> Bitterblue Smith gave the hint that this should not be per macid [3], so it should
> move
> out of struct ra_info.
> 
> [1]
> https://github.com/lwfinger/rtl8188eu/blob/master/hal/Hal8188ERateAdaptive.c
> #L248
> [2]
> https://github.com/lwfinger/rtl8188eu/blob/v5.2.2.4/hal8188erateadaptive.c#L
> 285
> [3]
> https://lore.kernel.org/linux-wireless/938ae608-a865-4056-06de-c230d74e1847@
> gmail.com/
> 

Thanks for the info. I can't find the log internally, so let's keep it 
as github does.

Ping-Ke