Re: [PATCH][v2] PCI: sysfs: Suppress FW_BUG warning when NUMA node already matches

From: Krzysztof Wilczyński

Date: Mon Mar 16 2026 - 21:21:01 EST


Hello,

The patch is very nice, so much cleaner now.

> The numa_node sysfs interface allows users to manually override a PCI
> device's NUMA node assignment. Currently, every write triggers a
> FW_BUG warning and taints the kernel, even when writing the same value
> that is already set.
>
> Check if the requested node is already assigned to the device. If it
> matches, return success immediately without tainting the kernel or
> printing a warning.

Something for future reference:

- The [PATCH][v2] would be better as [PATCH v2], as per the usual format
- The "PCI: sysfs" prefix that we use more often is "PCI/sysfs"

No need to send v3 just to fix this, unless someone (like Bjorn) would ask.

Thank you!

Krzysztof