Re: [PATCH v1 2/3] power: supply: Add PD SPR AVS support to USB type enum

From: Badhri Jagan Sridharan

Date: Mon Mar 16 2026 - 18:36:02 EST


On Mon, Mar 9, 2026 at 8:22 AM Sebastian Reichel
<sebastian.reichel@xxxxxxxxxxxxx> wrote:
>
> Hi,
>
> On Thu, Feb 26, 2026 at 05:53:10AM +0000, Badhri Jagan Sridharan wrote:
> > Add two new members to the power_supply_usb_type to represent the
> > USB Power Delivery (PD) Standard Power Range (SPR) Adjustable Voltage
> > Supply (AVS) charging types:
> >
> > POWER_SUPPLY_USB_TYPE_PD_SPR_AVS: For devices supporting only the
> > PD SPR AVS type.
> >
> > POWER_SUPPLY_USB_TYPE_PD_PPS_SPR_AVS: For devices that support both
> > PD Programmable Power Supply (PPS) and PD SPR AVS.
> >
> > Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx>
> > ---
> > drivers/power/supply/power_supply_sysfs.c | 2 ++
> > include/linux/power_supply.h | 3 +++
> > 2 files changed, 5 insertions(+)
>
> This is missing an update to Documentation/ABI/testing/sysfs-class-power .

Apologies, my bad, sent out a v2:
https://lore.kernel.org/lkml/20260316150301.3892223-1-badhri@xxxxxxxxxx/

Thanks Sebastian for taking a look.

Regards,
Badhri

>
> Greetings,
>
> -- Sebastian
>
> >
> > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> > index dd3a48d72d2b..f30a7b9ccd5e 100644
> > --- a/drivers/power/supply/power_supply_sysfs.c
> > +++ b/drivers/power/supply/power_supply_sysfs.c
> > @@ -70,6 +70,8 @@ static const char * const POWER_SUPPLY_USB_TYPE_TEXT[] = {
> > [POWER_SUPPLY_USB_TYPE_PD] = "PD",
> > [POWER_SUPPLY_USB_TYPE_PD_DRP] = "PD_DRP",
> > [POWER_SUPPLY_USB_TYPE_PD_PPS] = "PD_PPS",
> > + [POWER_SUPPLY_USB_TYPE_PD_SPR_AVS] = "PD_SPR_AVS",
> > + [POWER_SUPPLY_USB_TYPE_PD_PPS_SPR_AVS] = "PD_PPS_SPR_AVS",
> > [POWER_SUPPLY_USB_TYPE_APPLE_BRICK_ID] = "BrickID",
> > };
> >
> > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> > index 360ffdf272da..7a5e4c3242a0 100644
> > --- a/include/linux/power_supply.h
> > +++ b/include/linux/power_supply.h
> > @@ -210,6 +210,9 @@ enum power_supply_usb_type {
> > POWER_SUPPLY_USB_TYPE_PD, /* Power Delivery Port */
> > POWER_SUPPLY_USB_TYPE_PD_DRP, /* PD Dual Role Port */
> > POWER_SUPPLY_USB_TYPE_PD_PPS, /* PD Programmable Power Supply */
> > + /* PD Standard Power Range Adjustable Voltage Supply */
> > + POWER_SUPPLY_USB_TYPE_PD_SPR_AVS,
> > + POWER_SUPPLY_USB_TYPE_PD_PPS_SPR_AVS, /* Supports both PD PPS + SPR AVS */
> > POWER_SUPPLY_USB_TYPE_APPLE_BRICK_ID, /* Apple Charging Method */
> > };
> >
> > --
> > 2.53.0.414.gf7e9f6c205-goog
> >