Re: [PATCH 5.15 000/410] 5.15.202-rc2 review
From: Nathan Chancellor
Date: Mon Mar 16 2026 - 18:05:50 EST
On Thu, Mar 05, 2026 at 03:08:09PM -0700, Nathan Chancellor wrote:
> On Mon, Mar 02, 2026 at 11:09:55AM -0500, Sasha Levin wrote:
> > Jamie Iles (1):
> > i3c: remove i2c board info from i2c_dev_desc
>
> You missed commit 6cbf8b38dfe3 ("i3c: fix uninitialized variable use in
> i2c setup") as a fix for this one, as rightfully pointed out by clang:
>
> https://lore.kernel.org/177198114226.2577.15577566399399369654@d14e337afe00/
>
> $ make -skj"$(nproc)" ARCH=x86_64 LLVM=1 mrproper allmodconfig drivers/i3c/master.o
> drivers/i3c/master.c:2203:3: error: variable 'i2cdev' is uninitialized when used here [-Werror,-Wuninitialized]
> 2203 | i2cdev->dev = i2c_new_client_device(adap, &i2cboardinfo->base);
> | ^~~~~~
>
> I guess that report was missed because it was not actually addressed to
> anyone?
>
> FWIW, this patch appeared in a previous 5.15-rc release but Ben
> rightfully pointed out it really was not necessary and Greg said he
> would fix it up by hand:
>
> https://lore.kernel.org/2026011724-florist-brook-5f1f@gregkh/
>
> Guess that never happened?
Ping? I don't see 6cbf8b38dfe3 queued up in 5.15 and this continues to
break our builds:
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/23093834605
Cheers,
Nathan