Re: [patch 8/8] x86/vdso: Implement __vdso_futex_robust_try_unlock()

[Thomas Gleixner]

On Mon, Mar 16 2026 at 15:19, Mathieu Desnoyers wrote:
>> +uint32_t __vdso_futex_robust_try_unlock(uint32_t *lock, uint32_t tid, void *pop)
>
> I'm not sure I see the link between "list_pending_op" and @pop ?

What so hard to understand about that? The function prototype in
include/vdso/futex.h is extensively documented.

> [...]
>> +		: [tid] "+a" (tid)
>
> Could use a few comments:
>
> - "tid" sits in eax.

If someone needs a comment to understand the constraint, then that
persone definitely should not touch the code. I'm all for documentation
and comments, but documenting the obvious is not useful at all. See:

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#comment-style

I'm amazed that you complain about these obvious details and not about
the actual lack of a general comment which explains the actual inner
workings of that ASM maze. That would be actually useful for a
unexperienced reader. Interesting preference.

Thanks,

        tglx