Re: [PATCH] irqchip/qcom-mpm: Fix missing mailbox TX done acknowledgment

[Doug Anderson]

Hi,

On Mon, Mar 9, 2026 at 7:23 PM <jassisinghbrar@xxxxxxxxx> wrote:
>
> From: Jassi Brar <jassisinghbrar@xxxxxxxxx>
>
> The mbox_client for qcom-mpm sends NULL doorbell messages via
> mbox_send_message() but never signals TX completion.
> Set knows_txdone=true and call mbox_client_txdone() after a
> successful send, matching the pattern used by other Qualcomm
> mailbox clients (smp2p, smsm, qcom_aoss etc) of similar controller.
>
> Fixes: a6199bb514d8a6 "irqchip: Add Qualcomm MPM controller driver"
> Signed-off-by: Jassi Brar <jassisinghbrar@xxxxxxxxx>
> ---
>  drivers/irqchip/irq-qcom-mpm.c | 3 +++
>  1 file changed, 3 insertions(+)

OK, so it sounds like the consensus [0] is that we're _not_ going with
my mbox_ring_doorbell() approach [1] and we're instead going with some
sort of patch that makes NULL messages just like all other messages.
Maybe something based on Jassi's patch [2], or maybe something based
on Joonwon's patch [3].

Given that, then I think we'll need ${SUBJECT} patch. Thus:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

get_maintainer says that this driver goes through Thomas Gleinxer's
tree, but I didn't see him CCed. I added him to the "To" list. Seems
like he'd either need to take it, or Ack it to go through the mailbox
tree?

[0] https://lore.kernel.org/r/20260310234616.334498-1-jassisinghbrar@xxxxxxxxx
[1] https://lore.kernel.org/r/20260208040240.1971442-1-dianders@xxxxxxxxxxxx
[2] https://lore.kernel.org/r/20260310234616.334498-1-jassisinghbrar@xxxxxxxxx
[3] https://lore.kernel.org/r/20251126045926.2413532-1-joonwonkang@xxxxxxxxxx/