Re: [PATCH v4 6/7] iio: light: vcnl4000: use variables for I2C client and device instances
From: Andy Shevchenko
Date: Mon Mar 16 2026 - 16:04:13 EST
On Mon, Mar 16, 2026 at 07:19:50PM +0200, Erikas Bitovtas wrote:
> After moving data->client and client->dev into variables of their own,
> replace all instances of data->client and client->dev being used in
> vcnl4200_init and vcnl4000_probe by the said variables to reduce
vcnl4200_init()
vcnl4000_probe()
> clutter.
...
> - if (device_property_read_u32(&client->dev, "proximity-near-level",
> - &data->near_level))
> - data->near_level = 0;
> + device_property_read_u32(dev, "proximity-near-level", &data->near_level);
I meant to see this change in a separate patch after the current one.
This will be associated with a commit message explaining why it's okay
because it looks like a potential behaviour change (but actually not).
--
With Best Regards,
Andy Shevchenko