Re: [PATCH v4] tg3: replace placeholder MAC address with device property

[Michael Chan]

On Sat, Mar 14, 2026 at 2:54 PM Atharva Tiwari
<atharvatiwarilinuxdev@xxxxxxxxx> wrote:
>
> From: Paul SAGE <paul.sage@xxxxx>
>
> On some systems (e.g. iMac 20,1 with BCM57766), the tg3 driver reads
> a default placeholder mac address (00:10:18:00:00:00) from the
> mailbox. The correct value on those systems are stored in the
> 'local-mac-address' property.
>
> This patch, detect the default value and tries to retrieve
> the correct address from the device_get_mac_address
> function instead.
>
> The patch has been tested on two different systems:
> - iMac 20,1 (BCM57766) model which use the local-mac-address property
> - iMac 13,2 (BCM57766) model which can use the mailbox,
>     NVRAM or MAC control registers
>
> Tested-by: Rishon Jonathan R <mithicalaviator85@xxxxxxxxx>
>
> Co-developed-by: Vincent MORVAN <vinc@xxxxx>
> Signed-off-by: Vincent MORVAN <vinc@xxxxx>
> Signed-off-by: Paul SAGE <paul.sage@xxxxx>
> Signed-off-by: Atharva Tiwari <atharvatiwarilinuxdev@xxxxxxxxx>

Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature