Re: [PATCH v4] ALSA: hda/realtek: Sequence GPIO2 on Star Labs StarFighter

[Sean Rhodes]

Thank you :)

> On 16 Mar 2026, at 17:05, Takashi Iwai <tiwai@xxxxxxx> wrote:
> 
> On Sun, 15 Mar 2026 21:11:27 +0100,
> Sean Rhodes wrote:
>> 
>> The initial StarFighter quirk fixed the runtime suspend pop by muting
>> speakers in the shutup callback before power-down. Further hardware
>> validation showed that the speaker path is controlled directly by LINE2
>> EAPD on NID 0x1b together with GPIO2 for the external amplifier.
>> 
>> Replace the shutup-delay workaround with explicit sequencing of those
>> controls at playback start and stop:
>> - assert LINE2 EAPD and drive GPIO2 high on PREPARE
>> - deassert LINE2 EAPD and drive GPIO2 low on CLEANUP
>> 
>> This avoids the runtime suspend pop without a sleep, and also fixes pops
>> around G3 entry and display-manager start that the original workaround
>> did not cover.
>> 
>> Fixes: 1cb3c20688fc ("ALSA: hda/realtek: Fix speaker pop on Star Labs StarFighter")
>> Cc: Jaroslav Kysela <perex@xxxxxxxx>
>> Cc: Takashi Iwai <tiwai@xxxxxxxx>
>> Cc: Stefan Binding <sbinding@xxxxxxxxxxxxxxxxxxxxx>
>> Cc: Kailang Yang <kailang@xxxxxxxxxxx>
>> Cc: Chris Chiu <chris.chiu@xxxxxxxxxxxxx>
>> Cc: Edip Hazuri <edip@xxxxxxxxx>
>> Cc: linux-sound@xxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Tested-by: Sean Rhodes <sean@starlabs.systems>
>> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> 
> Applied now.  Thanks.
> 
> 
> Takashi