Re: [PATCH v2 1/3] dt-bindings: mtd: refactor NAND bindings and add nand-controller-legacy.yaml

[Rob Herring]

On Mon, Mar 16, 2026 at 9:37 AM Frank Li <frank.li@xxxxxxx> wrote:
>
> > > +select:
> > > +  allOf:
> > > +    - properties:
> > > +        $nodename:
> > > +          pattern: "^nand-controller(@.*)?"
> > > +    - not:
> > > +        properties:
> > > +          compatible:
> > > +            contains:
> > > +              pattern: "^fsl,"
> >
> > I would just do 'select: false' and make sure all non-legacy
> > controller bindings reference nand-controller.yaml.
>
> I found some controller have not compatible string, such as
> arch/arm/boot/dts/broadcom/bcm4708-luxul-xwc-1000.dts

It's there somewhere though the source structure makes it hard to
find. Converting the dtb back to flat dts gives this:

        nand-controller@18028000 {
                compatible = "brcm,nand-iproc", "brcm,brcmnand-v6.1",
"brcm,brcmnand";
                reg = <0x18028000 0x600 0x1811a408 0x600 0x18028f00 0x20>;
                reg-names = "nand", "iproc-idm", "iproc-ext";
                interrupts = <0x00 0x44 0x04>;
                #address-cells = <0x01>;
                #size-cells = <0x00>;
                brcm,nand-has-wp;

                nand@0 {
                        compatible = "brcm,nandcs";
                        reg = <0x00>;
                        #address-cells = <0x01>;
                        #size-cells = <0x01>;
                        nand-ecc-algo = "bch";
                        nand-ecc-strength = <0x08>;
                        nand-ecc-step-size = <0x200>;

                        partitions {
                                compatible = "fixed-partitions";
                                #address-cells = <0x01>;
                                #size-cells = <0x01>;

                                partition@0 {
                                        label = "ubi";
                                        reg = <0x00 0x8000000>;
                                };
                        };
                };
        };


>
> I am not sure if it is wrong. So I have not direct use "select false".
>
> Is it okay omit these dts?

Even if there are cases, yes.

Rob