RE: [PATCH v3 2/4] iio: adc: ad4691: add initial driver for AD4691 family

From: Sabau, Radu bogdan

Date: Mon Mar 16 2026 - 12:08:43 EST




> -----Original Message-----
> From: Nuno Sá <noname.nuno@xxxxxxxxx>
> Sent: Saturday, March 14, 2026 1:05 PM

...

> > +
> > + reset_control_assert(rst);
>
> You can get the reset in the asserted state already.
>

I'm not sure I fully follow your comment. Could you clarify what
you had in mind?

As far as I can tell, devm_reset_control_get_optional_exclusive()
doesn't guarantee the reset line is in any particular state upon
return - it depends on the system/bootloader. Keeping the
explicit reset_control_assert() before the delay makes the
sequence correct regardless of the initial hardware state,
and it's a no-op if the reset is already asserted.

If you are thinking of a specific API or pattern that gets the reset
handle in an asserted state, I am not really aware of it - but happy
to be corrected.

Thanks,
Radu