Re: [PATCH v2] platform/x86: asus-wmi: log thermal notification event

[Mario Limonciello]

On 3/16/26 07:49, Jonathan Grant wrote:
> [You don't often get email from jg@xxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
>  From e110b7489b320588a7d334bf0a4e20e3e25784e7 Mon Sep 17 00:00:00 2001
> From: Jonathan Grant <jg@xxxxxxxx>
> Date: Sat, 14 Mar 2026 02:11:09 +0000
> Subject: [PATCH] platform/x86: asus-wmi: log thermal notification event
>
> Print a diagnostic message when the ASUS WMI interface receives
> event 0x6d. This event was observed shortly before thermal
> shutdown on an ASUS N56VB under heavy system load. The message
> helps diagnose unexpected thermal power-offs.
>
> Signed-off-by: Jonathan Grant <jg@xxxxxxxx>
> ---
> v2:
>   - follow kernel patch guidelines
>   - rename event to NOTIFY_THERMAL
>   - document that event 0x6d was observed before thermal shutdown
>     on ASUS N56VB (BIOS WMI version 7.9, SFUN value 0x6a0877)
>   - improve commit message description
>   - remove stray blank line
>
>   drivers/platform/x86/asus-wmi.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 7c0915e097ba..6ab3886ad28f 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -70,6 +70,7 @@ module_param(fnlock_default, bool, 0444);
>   #define NOTIFY_KBD_TTP                 0xae
>   #define NOTIFY_LID_FLIP                        0xfa
>   #define NOTIFY_LID_FLIP_ROG            0xbd
> +#define NOTIFY_THERMAL                 0x6d
>
>   #define ASUS_WMI_FNLOCK_BIOS_DISABLED  BIT(0)
>
> @@ -4590,7 +4591,6 @@ static void asus_wmi_handle_event_code(int code, struct asus_wmi *asus)
>                  if (asus->throttle_thermal_policy_dev)
>                          platform_profile_cycle();
>                  return;
> -

You shouldn't change unrelated whitespace

>          }
>
>          if (is_display_toggle(code) && asus->driver->quirks->no_display_toggle)
> @@ -4598,7 +4598,10 @@ static void asus_wmi_handle_event_code(int code, struct asus_wmi *asus)
>
>          if (!sparse_keymap_report_event(asus->inputdev, code,
>                                          key_value, autorelease))
> -               pr_info("Unknown key code 0x%x\n", code);
> +               if (code == NOTIFY_THERMAL)
> +                       pr_info("Thermal state change\n");
> +               else
> +                       pr_info("Unknown key code 0x%x\n", code);
>   }
>
>   static void asus_wmi_notify(union acpi_object *obj, void *context)
> --
> 2.43.0