RE: [PATCH v3 2/4] iio: adc: ad4691: add initial driver for AD4691 family
From: Sabau, Radu bogdan
Date: Mon Mar 16 2026 - 10:31:20 EST
> -----Original Message-----
> From: Nuno Sá <noname.nuno@xxxxxxxxx>
> Sent: Saturday, March 14, 2026 1:05 PM
> > + ret = regmap_bulk_write(st->regmap, AD4691_ACC_MASK1_REG,
> acc_mask, 2);
> > + if (ret)
> > + return ret;
>
> Not DMA safe... Not sure if things changed in regmap_bulk_write() but before
> it was
> not guaranteed that a safe buffer was going to be used.
>
Hi Nuno!
What you are referring to here was my first thought too when implementing
bulk_write. However since we use custom .reg_write callbacksm, map->write
is NULL., therefore making regmap_bulk_write always fall into the individual
_regmap_write loop and calling our ad4691_reg_write -> spi_write_then_read
directly. So no DMA buffer allocation occurs on this path.