Re: [PATCH v2 2/3] scsi: virtio_scsi: remove unnecessary fn declaration

[Matthew Rosato]

On 3/12/26 1:42 PM, Joshua Daley wrote:
> virtscsi_handle_event() is not used before its definition, so remove
> a prior declaration.
> 
> Suggested-by: Eric Farman <farman@xxxxxxxxxxxxx>
> Signed-off-by: Joshua Daley <jdaley@xxxxxxxxxxxxx>
> ---
>  drivers/scsi/virtio_scsi.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> index 982f49bc6c69..6efbeaa30f65 100644
> --- a/drivers/scsi/virtio_scsi.c
> +++ b/drivers/scsi/virtio_scsi.c
> @@ -233,8 +233,6 @@ static void virtscsi_ctrl_done(struct virtqueue *vq)
>  	virtscsi_vq_done(vscsi, &vscsi->ctrl_vq, virtscsi_complete_free);
>  };
>  
> -static void virtscsi_handle_event(struct work_struct *work);
> -

Hi Josh,

You can't make this change until after patch 3 where you move the reference to virtscsi_handle_event further down.

In other words, if you just apply patch 1 + this patch you will get:

drivers/scsi/virtio_scsi.c:383:13: warning: ‘virtscsi_handle_event’ defined but not used [-Wunused-function]

until you also apply patch 3.  This breaks bisectability.

Please either re-arrange this series so that this is the last patch OR squash patch 2 + 3 together.

If you choose the latter approach and keep this patch then you can also include:

Reviewed-by: Matthew Rosato <mjrosato@xxxxxxxxxxxxx>

>  static int virtscsi_kick_event(struct virtio_scsi *vscsi,
>  			       struct virtio_scsi_event_node *event_node)
>  {