[PATCH 0/3] clk: rockchip: rk3588: add I2S MCLK output gate clocks
From: Daniele Briguglio
Date: Mon Mar 16 2026 - 09:38:03 EST
On RK3588, the four I2S master clock (MCLK) outputs to external IO
pins are gated by bits in SYS_GRF SOC_CON6 (offset 0x0318). These
are set-to-disable gates with hiword mask semantics.
The TRM documents the reset value of these bits as 0 (gate open),
but in practice the Rockchip firmware (BL31) may set them during
early boot, preventing the MCLK signal from reaching external audio
codecs. The kernel should manage these gates explicitly so that
audio functionality does not depend on bootloader register state.
This series adds GATE_GRF clock entries for all four I2S MCLK output
gates, following the same approach used for the RK3576 SAI MCLK
output gates [1]. Board DTS files that need MCLK on an IO pin can
reference these clocks (e.g. clocks = <&cru I2S0_8CH_MCLKOUT_TO_IO>),
ensuring the output gate is opened when the clock is enabled.
Patch 1 adds the four clock ID bindings.
Patch 2 removes the grf_type_sys exclusion from the aux_grf_table
lookup, which prevented SYS_GRF-based GATE_GRF entries from
being resolved on RK3588 (where ctx->grf points to PHP_GRF).
Patch 3 registers the SYS_GRF as an auxiliary GRF and adds the four
GATE_GRF clock entries, each placed after its parent MCLKOUT.
Tested on a Youyeetoo YY3588 (RK3588) board with an ES8388 audio
codec connected to I2S0. Without this series the firmware leaves the
gate closed and the codec receives no master clock. With the series
applied and DTS updated, audio playback works correctly.
[1] https://lore.kernel.org/r/20250305-rk3576-sai-v1-2-64e6cf863e9a@xxxxxxxxxxxxx/
Signed-off-by: Daniele Briguglio <hello@xxxxxxxxxxxx>
---
Daniele Briguglio (3):
dt-bindings: clock: rockchip,rk3588-cru: add I2S MCLK output to IO clock IDs
clk: rockchip: allow grf_type_sys lookup in aux_grf_table
clk: rockchip: rk3588: add GATE_GRF clocks for I2S MCLK output to IO
drivers/clk/rockchip/clk-rk3588.c | 22 ++++++++++++++++++++++
drivers/clk/rockchip/clk.c | 7 +++----
include/dt-bindings/clock/rockchip,rk3588-cru.h | 4 ++++
3 files changed, 29 insertions(+), 4 deletions(-)
---
base-commit: b84a0ebe421ca56995ff78b66307667b62b3a900
change-id: 20260316-rk3588-mclk-gate-grf-c4b180438fc0
Best regards,
--
Daniele Briguglio <hello@xxxxxxxxxxxx>