Re: [PATCH] drivers: s390: hmcdrv_dev: remove commented out code
From: Heiko Carstens
Date: Mon Mar 16 2026 - 09:23:47 EST
On Sun, Mar 08, 2026 at 11:32:51AM +0100, Jori Koolstra wrote:
> The create_class() api is retiring in favor of class_register() (see:
> https://lore.kernel.org/all/2023040244-duffel-pushpin-f738@gregkh/).
> The HMCDRV_DEV_CLASS define is hiding a use of create_class(), but it is
> permanently disabled as it is commented out. To avoid supporting code
> that is disabled, the suggestion is to remove all code hiding be behind
> any #ifdef HMCDRV_DEV_CLASS.
>
> Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jori Koolstra <jkoolstra@xxxxxxxxx>
> ---
> drivers/s390/char/hmcdrv_dev.c | 114 +--------------------------------
> 1 file changed, 1 insertion(+), 113 deletions(-)
Reviewed-by: Heiko Carstens <hca@xxxxxxxxxxxxx>
Vasily, will you pick this one up?