Re: [PATCH spi-next 11/11] spi: spi-fsl-lpspi: fsl_lpspi_set_bitrate(): don't treat devtype_data->prescale_max == 0 as a special case

[Marc Kleine-Budde]

On 16.03.2026 12:08:13, James Clark wrote:
> Those structs are configuration for different devices though. Having a 7 in
> there implies that it's something that is configurable to different values.
> When I was adding a new device that made be crawl through a load of
> datasheets to see why arbitrary values were needed only to find out that
> it's only for one errata where it's 1 and actually every other device should
> be 7.
>
> I tried to change it to a bool "has the errata" or "doesn't have it", as
> that's the extent of the valid configurations that should be exposed. But
> Frank said he preferred a number with 0 as the default. That seemed like a
> slight improvement to me so that's how it ended up like that.

Thanks for the insight, I'll drop the patch.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature