Re: [PATCH] drm/amdgpu/userq: fix memory leak in MQD creation error paths

From: Markus Elfring

Date: Mon Mar 16 2026 - 07:01:30 EST



> static int mes_userq_mqd_init_compute(struct amdgpu_device *adev,
> struct amdgpu_usermode_queue *queue,
> struct drm_amdgpu_userq_in *mqd_user,
> struct amdgpu_mqd_prop *userq_props)
> {
> struct drm_amdgpu_userq_mqd_compute_gfx11 *mqd __free(kfree) = NULL;


How do you think about to use a direct assignment without the variable initialisation “NULL”?

Regards,
Markus