Re: [PATCH 13/79] block: rnull: add memory backing
From: Alice Ryhl
Date: Mon Mar 16 2026 - 06:40:18 EST
On Mon, Feb 16, 2026 at 12:35:00AM +0100, Andreas Hindborg wrote:
> Add memory backing to the rust null block driver. This implementation will
> always allocate a page on write, even though a page backing the written
> sector is already allocated, in which case the page will be released again.
> A later patch will fix this inefficiency.
>
> Signed-off-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
Same comment as elsewhere about parsing booleans with kstrtobool.
> +type TreeNode = Owned<SafePage>;
> +type Tree = XArray<TreeNode>;
> +
> +#[pin_data]
> struct QueueData {
> + #[pin]
> + tree: Tree,
Why this type alias? Seems cleaner to just say
struct QueueData {
#[pin]
tree: XArray<TreeNode>,
Alice