RE: [PATCH v6 0/4] iio: adc: ad4080: add support for AD4880 dual-channel ADC

[Miclaus, Antoniu]

> -----Original Message-----
> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: Saturday, March 14, 2026 1:41 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@xxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; David Lechner <dlechner@xxxxxxxxxxxx>;
> Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; Andy Shevchenko <andy@xxxxxxxxxx>;
> Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>;
> Conor Dooley <conor+dt@xxxxxxxxxx>; Olivier Moysan
> <olivier.moysan@xxxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6 0/4] iio: adc: ad4080: add support for AD4880 dual-
> channel ADC
> 
> [External]
> 
> On Fri, 13 Mar 2026 13:58:49 +0200
> Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> wrote:
> 
> > Add support for the AD4880, a dual-channel 20-bit 40MSPS SAR ADC from
> > the same family as AD4080.
> >
> > The AD4880 has two independent ADC channels, each with its own SPI
> > configuration interface and LVDS data output. The driver uses
> > spi_new_ancillary_device() for the second channel's SPI and requires
> > two io-backend instances for the data interfaces.
> >
> > This series includes:
> >   - Use __free(fwnode_handle) for automatic cleanup in iio backend
> >   - Refactored devm_iio_backend_get_by_index() for multi-channel backend
> lookup
> >   - DT bindings update for AD4880
> >   - Driver support for AD4880
> >
> > This series depends on the SPI ancillary device patches already picked
> > up in Mark Brown's SPI tree
> (https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/gi
> t/broonie/spi.git__;!!A3Ni8CS0y2Y!4Ng6JS3ciBPGwHjV-
> Kah0kU9afOLLNPuUyEHkg8963vQV9xN3CFZlfzOXhDLETb0oh--
> OL5ap9VvYgc2MQ$ ).
> > Added base-commit in the cover letter below.
> >
> > Datasheet: https://www.analog.com/media/en/technical-
> documentation/data-sheets/ad4880.pdf
> >
> > Changes in v6:
> >   - Move fwnode_back declaration back to inline position above
> >     IS_ERR() check (patch 2)
> >   - Rebase on top of broonie/spi for-next and use --base to declare
> >     the SPI dependency (cover letter)
> 
> Ok. Given there was nothing in v5 to indicate a need to do a v6
> you should have replied to that thread to say you were doing so.
> The fwnode thing was something I said I'd fix up whilst applying.
> The SPI dependency was a 'do it better next time' comment.
> 
> I've dropped the v5 version I applied.  Now you have questions
> to answer from Andy on this one.

I saw you answered already some of them. The rest are some minor format stuff.

Should I wait for the v6 patchseries to go from "New" state to "Changes Requested" before sending a new v7?

I don't want to make the same mistake as I did for v5->v6 😊.

Regards,
> 
> >
> > Antoniu Miclaus (4):
> >   iio: backend: use __free(fwnode_handle) for automatic cleanup
> >   iio: backend: add devm_iio_backend_get_by_index()
> >   dt-bindings: iio: adc: ad4080: add AD4880 support
> >   iio: adc: ad4080: add support for AD4880 dual-channel ADC
> >
> >  .../bindings/iio/adc/adi,ad4080.yaml          |  53 +++-
> >  drivers/iio/adc/ad4080.c                      | 230 ++++++++++++++----
> >  drivers/iio/industrialio-backend.c            |  62 +++--
> >  include/linux/iio/backend.h                   |   2 +
> >  4 files changed, 278 insertions(+), 69 deletions(-)
> >
> >
> > base-commit: 2cd3974b9ae59ac731a4792e1608be32621b6e98
> > --
> > 2.43.0
> >