Re: [PATCH v4 1/5] dt-bindings: embedded-controller: Add EC bindings for Qualcomm reference devices

[Anvesh Jain P]

On 3/14/2026 12:31 AM, Krzysztof Kozlowski wrote:
> On 13/03/2026 11:29, Anvesh Jain P wrote:
>> From: Maya Matuszczyk <maccraft123mc@xxxxxxxxx>
>>
>> Add bindings for the EC firmware running on Hamoa/Purwa and Glymur
>> reference devices.
>>
>> Signed-off-by: Maya Matuszczyk <maccraft123mc@xxxxxxxxx>
>> Co-developed-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
>> Co-developed-by: Anvesh Jain P <anvesh.p@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Anvesh Jain P <anvesh.p@xxxxxxxxxxxxxxxx>
> 
> A nit, subject: drop second/last, redundant "bindings for". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Noted, will fix the subject in v5.

> 
>> ---
>>  .../embedded-controller/qcom,hamoa-ec.yaml         | 56 ++++++++++++++++++++++
>>  1 file changed, 56 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml
>> new file mode 100644
>> index 000000000000..baa95f06644a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml
>> @@ -0,0 +1,56 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/embedded-controller/qcom,hamoa-ec.yaml#
> 
> Filename must match compatible.
> 
> This is a standard review comment already documented in kernel and your
> internal guideline, no?
>

You're right. The filename qcom,hamoa-ec.yaml does not match the base
compatible qcom,hamoa-crd-ec. Will rename the file to
qcom,hamoa-crd-ec.yaml and update the $id accordingly in v5.

Thanks for the review!

-- 
Best Regards,
Anvesh