Re: [PATCH 1/2] pinctrl: stmfx: fix mfd dependency

[Linus Walleij]

On Thu, Mar 12, 2026 at 9:18 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:

> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The PINCTRL_STMFX driver attempts to force-enable its MFD parent
> driver, which is really the wrong way around compared to general
> conventions. After the OF_GPIO dependency got dropped, this leads
> to a harmless but annoying build warning:
>
> WARNING: unmet direct dependencies detected for MFD_STMFX
>   Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n]
>   Selected by [m]:
>   - PINCTRL_STMFX [=m] && PINCTRL [=y] && I2C [=y] && HAS_IOMEM [=y]
>
> Change the 'select' into a dependency instead. As this changes the
> defconfig behavior, also change the generic arm defconfig file to enable
> the other symbol instead.
>
> Fixes: e785c990adcc ("pinctrl: Kconfig: drop unneeded dependencies on OF_GPIO")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij