Re: [PATCH 0/4] gpio: kempld: Support get/set multiple and interrupts

[Linus Walleij]

On Wed, Mar 11, 2026 at 3:31 PM Alban Bedel <alban.bedel@xxxxxxxxxx> wrote:

> This series update the kempld driver to support current versions of the PLD,
> add the get/set multiple ops and implement the interrupt controller.

The series is fine, I think it is worth noticing the following however:

The kempld MFD device is just providing kempld_read8()
kempld_write8() etc. These in turn are not very magical.

If the MFD device was refactored to just use regmap for
read/write of these registers, the whole GPIO driver could
be cut down a lot by using GPIO_REGMAP.

I think this is a common problem with a bunch of
"necessarily different" MFD driver APIs that should be using
regmap but weren't caught during review.

Yours,
Linus Walleij