RE: [PATCH 2/2] dt-bindings: hwmon: isl68137: Add compatible string for RAA228942 and RAA228943

[Dawei Liu]

Hi Krzysztof,

Thank you for the review.

The RAA228942/228943 are register-compatible with RAA228228/244/246
family, using the same PMBus command set and the raa_dmpvr2_2rail_nontc 
driver configuration (2-rail without TEMP3 sensor). 

In the driver code, they reuse the existing device configuration, so no 
special handling is needed. That's why they're added to the enum list in 
the binding.

I will send v2 with improved commit messages to clarify this.


Best Regards
Dawei Liu

-----Original Message-----
From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> 
Sent: Monday, March 16, 2026 4:26 PM
To: Dawei Liu <dawei.liu.jy@xxxxxxxxxxx>
Cc: linux@xxxxxxxxxxxx; linux-hwmon@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; corbet@xxxxxxx; skhan@xxxxxxxxxxxxxxxxxxx; geert+renesas@xxxxxxxxx; magnus.damm <magnus.damm@xxxxxxxxx>; Grant Peltier <grant.peltier.jg@xxxxxxxxxxx>
Subject: Re: [PATCH 2/2] dt-bindings: hwmon: isl68137: Add compatible string for RAA228942 and RAA228943

[Some people who received this message don't often get email from krzk@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On Mon, Mar 16, 2026 at 01:35:41PM +0800, Dawei Liu wrote:
> Add compatible strings for the Renesas RAA228942 and RAA228943 digital 
> dual-output 16-Phase PWM controllers.
>
> Signed-off-by: Dawei Liu <dawei.liu.jy@xxxxxxxxxxx>

Please read submitting patches in bindings and process directories.

> ---
>  .../devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml          | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git 
> a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml 
> b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> index ae23a0537..53d07c0ce 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> @@ -56,6 +56,8 @@ properties:
>        - renesas,raa228228
>        - renesas,raa228244
>        - renesas,raa228246
> +      - renesas,raa228942
> +      - renesas,raa228943

So are they compatible or they are not compatible with anything else, like driver suggests? That's what commit msg is for as well.

Best regards,
Krzysztof