Re: [PATCH 4/9] pinctrl: qcom: Introduce IPQ5210 TLMM driver

[Kathiravan Thirumoorthy]

On 3/13/2026 6:24 PM, Konrad Dybcio wrote:
> On 3/11/26 10:45 AM, Kathiravan Thirumoorthy wrote:
> > Qualcomm's IPQ5210 SoC comes with a TLMM block, like all other platforms,
> > so add a driver for it.
> >
> > Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@xxxxxxxxxxxxxxxx>
> > ---
> [...]
>
> > +static const char *const Led00_groups[] = {
> odd uppercase


Yeah,  in HW document also only this name has the uppercase. So I just 
left it to align with the HW document. Do you prefer to change it to 
lower case to maintain consistency?


> > +	"gpio23",
> > +};
> > +
> > +static const char *const led01_groups[] = {
> > +	"gpio39",
> > +};
> > +
> > +static const char *const led02_groups[] = {
> > +	"gpio6",
> > +};
> What do these 'ledN[012]' functions represent? Are they muxes for
> getting activity/status signals for eth/wlan ports?


Yes, that's right. These LED functions used for the eth/wlan status.


> Konrad