Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones

[Krzysztof Kozlowski]

On 16/03/2026 08:33, Gaurav Kohli wrote:
> 
> 
> On 3/14/2026 4:01 PM, Krzysztof Kozlowski wrote:
>> On Fri, Mar 13, 2026 at 04:04:18PM +0530, Gaurav Kohli wrote:
>>> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@xxxxxxxxxxx>
>>>
>>> The sm8750 includes four TSENS instances, with a total of 47 thermal
>>> sensors distributed across various locations on the SoC.
>>>
>>> The TSENS max/reset threshold is configured to 130°C in the hardware.
>>> Enable all TSENS instances, and define the thermal zones with a hot trip
>>> at 120°C and critical trip at 125°C.
>>>
>>> Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@xxxxxxxxxxx>
>>> Signed-off-by: Gaurav Kohli <gaurav.kohli@xxxxxxxxxxxxxxxx>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sm8750.dtsi | 897 +++++++++++++++++++++++++++++++++++
>>>   1 file changed, 897 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> index f56b1f889b85..db2a97cb228d 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> @@ -20,6 +20,7 @@
>>>   #include <dt-bindings/soc/qcom,gpr.h>
>>>   #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>>>   #include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
>>> +#include <dt-bindings/thermal/thermal.h>
>>>   
>>>   / {
>>>   	interrupt-parent = <&intc>;
>>> @@ -5457,6 +5458,902 @@ compute-cb@14 {
>>>   				};
>>>   			};
>>>   		};
>>> +
>>> +		tsens0: thermal-sensor@c228000 {
>>
>> Please read carefully DTS coding style before posting patches. Actually,
>> read also Linux kernel coding style as well.
>>
> 
> Thanks Krzysztof for review.
> 
> Can i use temperature-sensor instead of thermal-sensor as per 
> generic-names-recommendation ?

Both work for me.

Best regards,
Krzysztof