Re: [PATCH v2 05/10] staging: axis-fifo: improve IRQ handler

[Dan Carpenter]

On Mon, Mar 02, 2026 at 03:55:36PM +0000, Josh Law wrote:
> 2 Mar 2026 08:14:53 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> 
> > On Sun, Mar 01, 2026 at 09:48:10PM +0000, Josh Law wrote:
> >> From: Josh Law <objecting@xxxxxxxxxxxxx>
> >>
> >> Return IRQ_NONE when no interrupts were triggered to avoid spurious
> >> interrupt storms, and only clear the active interrupts instead of
> >> blindly clearing all interrupts by writing 'intr' to the ISR instead of
> >> XLLF_INT_CLEAR_ALL.
> >>
> >
> > Is this something you actually experienced in real life?  The commit
> > message needs to be clearer about that.
> >
> > regards,
> > dan carpenter
> 
> Hello Dan, It's just code optimizations, making it cleaner, etc, I
> also ran all of these latest V2 commits through check patch, to make
> sure they are compliant, I own this device so I hope I can be the
> maintainer of it one day, I'm learning this Linux system day by day,
> so I am sorry I have to annoy a professional linaro dev like you haha
> 

I don't mind reviewing patches.  The cleanups are easy to review.  In
this case it's a behavior change and so I would want a clearer picture
the motivation and of how well these have been tested for that.

regards,
dan carpenter