Re: [PATCH] USB: typec: tcpci: Make tcpci_pm_ops variable static
From: Greg Kroah-Hartman
Date: Wed Feb 18 2026 - 15:58:32 EST
On Wed, Feb 18, 2026 at 12:35:04PM -0800, Badhri Jagan Sridharan wrote:
> On Mon, Feb 16, 2026 at 3:04 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxxxxx> wrote:
> >
> > File-scope 'tcpci_pm_ops' is not used outside of this unit, so make it
> > static to silence sparse warning:
> >
> > tcpm/tcpci.c:1002:1: warning: symbol 'tcpci_pm_ops' was not declared. Should it be static?
> >
>
> Thanks for sending the patch Krzysztof !
> Can you also please add "Fixes:" and "Cc: stable@xxxxxxxxxxxxxxx" ?
Why would a sparse warning fix need either of those? Are you wanting to
just pre-load my "WTF" email bot to go off? :)
thanks,
greg k-h