Re: [PATCH net-next v2] net: replace ND_PRINTK with dynamic debug

From: Simon Horman
Date: Fri Jul 04 2025 - 10:19:25 EST


On Tue, Jul 01, 2025 at 04:11:14PM +0800, Wang Liang wrote:
> ND_PRINTK with val > 1 only works when the ND_DEBUG was set in compilation
> phase. Replace it with dynamic debug. Convert ND_PRINTK with val <= 1 to
> net_{err,warn}_ratelimited, and convert the rest to net_dbg_ratelimited.
>
> Suggested-by: Ido Schimmel <idosch@xxxxxxxxxx>
> Signed-off-by: Wang Liang <wangliang74@xxxxxxxxxx>
> ---
> Changes in v2:
> Use dynamic debug instead of sysctl.

Thanks, I agree this addresses Ido's review of v1.
And, moreover, is a good approach the problem at hand.