Re: [PATCH v5 3/3] cpufreq: tegra124: Allow building as a module
From: Aaron Kling
Date: Thu Jul 03 2025 - 14:34:38 EST
On Wed, Jul 2, 2025 at 3:12 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 02-07-25, 02:46, Aaron Kling via B4 Relay wrote:
> > +static struct platform_device *platform_device;
>
> Maybe initialize this to an error value...
>
> > +static void __exit tegra_cpufreq_module_exit(void)
> > +{
> > + if (platform_device && !IS_ERR(platform_device))
>
> ... and then this could be simplified ?
>
> Or use !IS_ERR_OR_NULL .
Latter sounds better to me. I'll queue that up and send a new patchset
in a couple days, pending any further comments.
Aaron