Re: [PATCH v7] dt-bindings: net: Convert socfpga-dwmac bindings to yaml

[Matthew Gerlach]

On 7/3/25 8:30 AM, Rob Herring wrote:
> On Mon, Jun 30, 2025 at 4:38 PM Matthew Gerlach
> <matthew.gerlach@xxxxxxxxxx> wrote:
> >
> > Convert the bindings for socfpga-dwmac to yaml. Since the original
> > text contained descriptions for two separate nodes, two separate
> > yaml files were created.
>
> Did you test this against your dts files?:
I have a log file with a clean test, but I must have overlooked the 
errors below in subsequent tests.
> ethernet@ff804000 (altr,socfpga-stmmac-a10-s10): iommus: [[11, 3]] is too short
> ethernet@ff802000 (altr,socfpga-stmmac-a10-s10): iommus: [[11, 2]] is too short
> ethernet@ff800000 (altr,socfpga-stmmac-a10-s10): iommus: [[11, 1]] is too short
>
> There's also one for 'phy-addr', but that needs to be dropped from the
> .dts files as it doesn't appear to be used.
I see the phy-addr error. It is coming from Arria10 .dts files. I can 
submit a patch set dropping the phy-addr property.

> [...]
>
> > +  iommus:
> > +    maxItems: 2
>
> You need to add:
>
> minItems: 1
Thanks for the hint. Should I submit a "fixes" patch that adds the 
'minItems: 1', or should I submit a v8 patch with the whole conversion 
plus the 'minItems: 1'?

Matthew Gerlach

> Rob