Re: [PATCH v2 2/3] pinctrl: renesas: Add support for RZ/T2H

[Geert Uytterhoeven]

Hi Prabhakar,

On Wed, 25 Jun 2025 at 15:07, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx>
>
> Add the pinctrl and gpio driver for RZ/T2H
>
> Signed-off-by: Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx>
> Co-developed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> v1->v2:
> - All the regions are now accessed by reg names
> - Added support to validate the pins

Thanks for the update!

> --- a/drivers/pinctrl/renesas/Kconfig
> +++ b/drivers/pinctrl/renesas/Kconfig
> @@ -44,6 +44,7 @@ config PINCTRL_RENESAS
>         select PINCTRL_RZG2L if ARCH_R9A09G047
>         select PINCTRL_RZG2L if ARCH_R9A09G056
>         select PINCTRL_RZG2L if ARCH_R9A09G057
> +       select PINCTRL_RZT2H if ARCH_R9A09G077
>         select PINCTRL_PFC_SH7203 if CPU_SUBTYPE_SH7203
>         select PINCTRL_PFC_SH7264 if CPU_SUBTYPE_SH7264
>         select PINCTRL_PFC_SH7269 if CPU_SUBTYPE_SH7269
> @@ -249,6 +250,18 @@ config PINCTRL_RZN1
>         help
>           This selects pinctrl driver for Renesas RZ/N1 devices.
>
> +config PINCTRL_RZT2H
> +       bool "pin control support for RZ/T2H"
> +       depends on OF
> +       depends on ARCH_R9A09G077 || COMPILE_TEST

This line is not needed, as PINCTRL_RZT2H is selected above (On RZ/A1,
RZ/A2, and RZ/N1, the pin control driver is optional).  Please move the
"|| COMPILE_TEST" to the prompt, like is done for most other drivers.

> +       select GPIOLIB
> +       select GENERIC_PINCTRL_GROUPS
> +       select GENERIC_PINMUX_FUNCTIONS
> +       select GENERIC_PINCONF
> +       help
> +         This selects GPIO and pinctrl driver for Renesas RZ/T2H
> +         platforms.
> +
>  config PINCTRL_RZV2M
>         bool "pin control support for RZ/V2M"
>         depends on OF

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds