Re: [PATCH v1 3/4] ASoC: dt-bindings: Add dt bindings for FS2104/5S audio amplifiers

[Krzysztof Kozlowski]

On Thu, Jul 03, 2025 at 11:56:38AM +0800, Nick wrote:
> From: Nick Li <nick.li@xxxxxxxxxxxx>
> 
> This patch adds bindings for FourSemi FS2104/5S audio amplifiers
> which can support both I2S and I2C interface.
> 
> Signed-off-by: Nick Li <nick.li@xxxxxxxxxxxx>
> ---
>  .../bindings/sound/foursemi,fs210x.yaml       | 95 +++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/foursemi,fs210x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/foursemi,fs210x.yaml b/Documentation/devicetree/bindings/sound/foursemi,fs210x.yaml
> new file mode 100644
> index 000000000..3a1aba9b8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/foursemi,fs210x.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: GPL-2.0-only

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof