Re: [PATCH v2 2/3] arm64: dts: qcom: x1-hp-x14: Commonalize HP Omnibook X14 device tree

[Dmitry Baryshkov]

On Wed, Jul 02, 2025 at 11:22:34PM +0200, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
> 
> Commonalize the HP Omnibook X14 device tree for derivation of Hamoa (x1e*/x1p6*)
> and Purwa (x1p4*/x1*) variants. Required because the device trees are not
> compatible.
> 
> Signed-off-by: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi   | 1550 ++++++++++++++++++++
>  .../boot/dts/qcom/x1e80100-hp-omnibook-x14.dts     | 1544 +------------------
>  2 files changed, 1554 insertions(+), 1540 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi b/arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi
> new file mode 100644
> index 0000000000000000000000000000000000000000..7d4a474215ac97096c49e1f690229d07198c022e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi
> @@ -0,0 +1,1550 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
> + * Copyright (c) 2024, Xilin Wu <wuxilin123@xxxxxxxxx>
> + * Copyright (c) 2024, 2025 Jens Glathe

Nit: what exactly is copyright by you?



> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> index 8d2a9b7f4730783bbaa81e488a0e99cc195a195f..b81cafea2135e869ba3652aeeec142d54033bef3 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> @@ -2,860 +2,19 @@
>  /*
>   * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
>   * Copyright (c) 2024, Xilin Wu <wuxilin123@xxxxxxxxx>
> + * Copyright (c) 2025 Jens Glathe

Same question.

>   */
>  
>  /dts-v1/;
>  
> -#include <dt-bindings/gpio/gpio.h>
> -#include <dt-bindings/input/gpio-keys.h>
> -#include <dt-bindings/input/input.h>
> -#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> -#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> -
>  #include "x1e80100.dtsi"
>  #include "x1e80100-pmics.dtsi"
> +#include "x1-hp-omnibook-x14.dtsi"

If you need to send the series again, please pass -M -C
--find-copies-harder to git format-patch

-- 
With best wishes
Dmitry