Re: [tip:master 19/19] include/linux/irq-entry-common.h:201:2: error: unexpected token

[Peter Zijlstra]

On Wed, Jul 02, 2025 at 04:54:25PM +0200, Peter Zijlstra wrote:
> On Wed, Jul 02, 2025 at 03:16:01PM +0100, Mark Rutland wrote:
> > On Wed, Jul 02, 2025 at 03:24:15PM +0200, Borislav Petkov wrote:
> > > On Wed, Jul 02, 2025 at 02:16:15PM +0100, Mark Rutland wrote:
> > > > Sounds like a plan.
> > > 
> > > As we figured out on IRC:
> > > 
> > > https://lore.kernel.org/all/20250616-loongarch-fix-warn-cond-llvm-ias-v1-1-6c6d90bb4466@xxxxxxxxxx/
> > > 
> > > "clang's integrated assembler only supports concatenating strings with
> > > '.ascii'. There was discussion of allowing '.string' / '.asciz' but it
> > > was decided against [1] because it was undesirable to match the behavior
> > > of released binutils at the time, where"
> > > 
> > > and this seems to fix it here:
> > > 
> > > ---
> > > diff --git a/arch/s390/include/asm/bug.h b/arch/s390/include/asm/bug.h
> > > index a185855ab158..46d9eb64bd18 100644
> > > --- a/arch/s390/include/asm/bug.h
> > > +++ b/arch/s390/include/asm/bug.h
> > > @@ -9,7 +9,7 @@
> > >  #else
> > >  #define __BUGVERBOSE_LOCATION(file, line)			\
> > >  		.pushsection .rodata.str, "aMS", @progbits, 1;	\
> > > -	10002:	.string file;					\
> > > +	10002:	.ascii file;					\
> > >  		.popsection;					\
> > >  								\
> > >  		.long 10002b - .;				\
> > > 
> > 
> > IIUC this also needs a trailing "\0" as per the link above, or this
> > won't get a NUL-terminator (but will build just fine).
> 
> Yup, I ran into this before. Let me go fix that commit.

 + e7e26cfad96c...2a20b2730147 core/bugs -> core/bugs (forced update)