RE: [PATCH v4 4/4] arm64: dts: renesas: rzg3e-smarc-som: Enable eth{0-1} (GBETH) interfaces

[John Madieu]

Hi Geert,

Thanks for your review.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Wednesday, July 2, 2025 11:03 AM
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v4 4/4] arm64: dts: renesas: rzg3e-smarc-som: Enable
> eth{0-1} (GBETH) interfaces
> 
> Hi John,
> 
> On Wed, 2 Jul 2025 at 02:57, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> wrote:
> > Enable the Gigabit Ethernet Interfaces (GBETH) populated on the RZ/G3E
> > SMARC EVK
> >
> > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> 
> > v4:
> >  - Update pinmux to add OEN support
> >  - Drops Tb and Rb tags initially collected
> 
> Thanks for the update!
> 
> > --- a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> >  &pinctrl {
> > +       eth0_pins: eth0 {
> > +               clk0 {
> 
> No need for the 0 ...
> 
> > +                       pinmux = <RZG3E_PORT_PINMUX(B, 1, 1)>; /* TXC */
> > +                       output-enable;
> > +               };
> > +
> > +               ctrl0 {
> 
> ... suffixes...
> 
> > +       eth1_pins: eth1 {
> > +               clk1 {
> 
> ... or the 1...
> 
> > +                       pinmux = <RZG3E_PORT_PINMUX(E, 1, 1)>; /* TXC */
> > +                       output-enable;
> > +               };
> > +
> > +               ctrl1 {
> 
> ... suffixes.
> 
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in
> renesas-devel for v6.17 with the above fixed.

Thanks for taking care of that.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 

Regards,
John

> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
>                                 -- Linus Torvalds